feat: allow to override perms on commands in bulk.#3417
feat: allow to override perms on commands in bulk.#3417lorenzo132 wants to merge 13 commits intodevelopmentfrom
Conversation
lorenzo132
requested review from
a team,
StephenDaDev,
Taaku18,
martinbndr and
sebkuip
StephenDaDev
left a comment
StephenDaDev
left a comment
There was a problem hiding this comment.
I think that there should be consideration for more of the user prompts to be in embeds. It does not make sense that some are and some are not. Additionally, I think that errors should be output as an embed similar to other "errors" in the bot.
I also included one other QOL comment.
StephenDaDev
added
the
changelog
This aswell automatically skips invalid provided commands.
There was a problem hiding this comment.
Pull request overview
This pull request adds a bulk override feature to the permissions system, allowing administrators to update permission levels for multiple commands at once through an interactive flow.
Changes:
- Modified the
permissions_overridecommand to support a special "bulk" mode - Added a new interactive flow (
_bulk_override_flow) with multi-step confirmation using Discord UI components - Made the
level_nameparameter optional to accommodate the bulk mode routing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sebkuip
left a comment
sebkuip
left a comment
There was a problem hiding this comment.
Small changes to how invalid command processing is handled. Should hopefully be a quick fix.
sebkuip
left a comment
sebkuip
left a comment
There was a problem hiding this comment.
Only logging needs to be fixed.
sebkuip
left a comment
sebkuip
left a comment
There was a problem hiding this comment.
Since all my previous comments were fixed/addressed, this seems fine to merge
LGTM
4 participants
No description provided.